Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: returnDataToKernel #44

Merged
merged 56 commits into from
Nov 28, 2024

Conversation

shiv810
Copy link
Collaborator

@shiv810 shiv810 commented Nov 9, 2024

Resolves #43

  • Previous failed runs still retained data, and the corresponding comment/issues should be present in the database. As far as I know, this isn’t running on either the organization’s supabase instance or mine.
  • Fixed the returnDataToKernel, was missing GITHUB_TOKEN in compute.yml
  • QA Action Runs: Link
  • Good values for thresholds:
matchThreshold: 0.9
warningThreshold: 0.7
jobMatchingThreshold: 0.7

@shiv810 shiv810 requested a review from Keyrxng November 9, 2024 15:25
@shiv810 shiv810 requested a review from 0x4007 November 22, 2024 14:36
@gentlementlegen
Copy link
Member

@sshivaditya2019 Did you retry with the newly added SDK?

@shiv810
Copy link
Collaborator Author

shiv810 commented Nov 26, 2024

@sshivaditya2019 Did you retry with the newly added SDK?

Working on that, but the action runs are failing Error: Invalid Signature

https://github.com/sshivaditya2019/issue-comment-embeddings/actions/runs/12026186288/job/33524665317

KERNEL_PUBLIC_KEY is optional right ?

@gentlementlegen
Copy link
Member

gentlementlegen commented Nov 26, 2024

Yes it is optional but you will get the invalid signature error if it doesn't match the kernel in use. In this org it's fine because it is defined for dev and production. Locally you can disable it if you need to test.
To test in your org you should set it in the action secrets that matches your kernel private key.

Copy link
Contributor

github-actions bot commented Nov 26, 2024

Unused devDependencies (1)

Filename devDependencies
package.json @vercel/ncc

@shiv810
Copy link
Collaborator Author

shiv810 commented Nov 26, 2024

@gentlementlegen, do you know why dist/index.js is throwing the error Error: Process completed with exit code 1? The plugin works fine when used without compiling. Is there a way to debug this issue? The action-deploy-plugin successfully built the dist file and updated the manifest.json.

Action: Run

@gentlementlegen
Copy link
Member

You should use ncc locally and try to run it without minifying so you can see the error clearly. A guess is that the plugin is compiled as ESM when it should be CJS or vice versa.

@shiv810
Copy link
Collaborator Author

shiv810 commented Nov 27, 2024

QA: Run

File Changed: Issue Link

@shiv810
Copy link
Collaborator Author

shiv810 commented Nov 27, 2024

@gentlementlegen The NCC error and the action error have both been fixed.

package.json Outdated Show resolved Hide resolved
@gentlementlegen
Copy link
Member

@sshivaditya2019 tested, works on my side: https://github.com/Meniole/text-vector-embeddings/actions/runs/12063952321/job/33639960768
Can you please just add the gql file I recommended then good to merge.

@shiv810
Copy link
Collaborator Author

shiv810 commented Nov 28, 2024

Can you please just add the gql file I recommended then good to merge.

I’ve added graphql.config.yml.

@shiv810 shiv810 merged commit 8ec56e7 into ubiquity-os-marketplace:development Nov 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actions are not working
5 participants